Conversation
SeedRizvi
force-pushed
the
kria_k26_support
branch
2 times, most recently
from
2a06735 to
332577f
Compare
midnightveil
left a comment
midnightveil
left a comment
There was a problem hiding this comment.
LGTM after seL4 changes are merged and pulled in-tree.
Ivan-Velickovic
force-pushed
the
kria_k26_support
branch
from
651363d to
5b1293b
Compare
|
This has now been refactored to instead work without any changes to seL4 by placing the overlay file directly within Microkit based on commit b866313. |
build_sdk.py
Outdated
| elif isinstance(val, KernelPath): | ||
| str_val = f"{sel4_dir.absolute()}/{val.path}" | ||
| elif isinstance(val, Path): | ||
| str_val = val.absolute() |
There was a problem hiding this comment.
this probably shouldn't just be val.absolute() which goes relative to the current directory, we should probably go relative to where build_sdk is located.
There was a problem hiding this comment.
Also, adding KernelPath doesn't seem an improvement compared to the original code? It makes things more complicated with no gain as far as I can tell.
There was a problem hiding this comment.
Some of the DTS overlays are local to Microkit while some come from the kernel, we need to be able to refer to paths relative to both. The path to seL4 is supplied by the user so we need a way of converting to a kernel relative path.
There was a problem hiding this comment.
Can't you just check both locations? If it's not locally present, try to find it in the kernel path?
There was a problem hiding this comment.
We can, I did this since I preferred it to be a bit more explicit. I can change it to just search both locations instead though.
We removed this f37bb59 but there are some cases where the Microkit board is more specific than the seL4 platform. One example of this is where it is the same exact SoC but say the default UART is different for one board is different to another. Until the loader is more generic (e.g parsing the DTB) we have to do something like this. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
kria_k26_support
branch
from
4783f32 to
54b7fc1
Compare
A bit annoying since when we refer to the kernel path we don't know exactly where the kernel is since it's a user-supplied argument Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Signed-off-by: SeedRizvi <syedasadrazarizvi1@gmail.com> Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
kria_k26_support
branch
from
54b7fc1 to
dc307e6
Compare
4 participants
Add the AMD/Xilinx Kria K26 SOM as a supported board, which is largely similar to ZCU102. Made with support from @potanin .
This is part of a set of related PRs across microkit, seL4, sDDF, and seL4-docs to add Kria K26 support.
build_sdk.py: registerkria_k26withKernelARMPlatform=kria_k26loader/src/uart.c: add UART support using base address0xff010000(UART1), integrated with the pre-existing ZCU102 #define block as it's identicalloader/src/aarch64/init.c: skip PSCI version check for Kria K26 platform